[v0.4] gke 1.6.0 #258
Merged
[v0.4] gke 1.6.0 #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andypitcher
requested changes
Oct 16, 2024
There was a problem hiding this comment.
LGTM, could you just adjust the cfgs list within e2e:
Line 63 in 2b9c8d1
We could have a separate PR to remove/add the cfgs for the given release.
done. And updated the PR description |
vardhaman22
force-pushed
the
v2.9-gke-1.6.0
branch
from
cd11350
to
9318f7c
Compare
vardhaman22
force-pushed
the
v2.9-gke-1.6.0
branch
from
9318f7c
to
6e96812
Compare
andypitcher
approved these changes
Oct 18, 2024
vardhaman22
force-pushed
the
v2.9-gke-1.6.0
branch
from
6e96812
to
1bcdae8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: rancher/rancher#47552
Note: gke 1.2.0 is not removed since gke 1.6.0 is only for versions >=1.29 and other gke profiles are not available in upstream kube-bench and the minimum supported k8s version in rancher v2.8 is 1.25