📖 docs: add helm chart repository adr #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salasberryfin
added
the
kind/documentation
salasberryfin
force-pushed
the
adr-publish-chart-to-rancher
branch
3 times, most recently
from
4971324 to
51a029c
Compare
salasberryfin
changed the title
salasberryfin
force-pushed
the
adr-publish-chart-to-rancher
branch
from
51a029c to
ca0ef5f
Compare
|
I updated the ADR with the final decision. Also expanded on some topics that were not as clear as expected, as reported by @Danil-Grigorev. |
richardcase
previously approved these changes
Mar 13, 2024
Danil-Grigorev
added
kind/proposal
salasberryfin
force-pushed
the
adr-publish-chart-to-rancher
branch
from
ca0ef5f to
fdb53c2
Compare
There was a problem hiding this comment.
+1 on using custom chart repo, as it would drag us out of the unneccessary complications&mess that rancher/charts would bring (based on hosted provider experience). However, I would suggest to expand a bit how Kubewarden does it without using it, because by just reading, it was not clear to me.
salasberryfin
force-pushed
the
adr-publish-chart-to-rancher
branch
from
fdb53c2 to
b15f5bc
Compare
|
@salasberryfin please fix the CI failure, otherwise this LGTM |
salasberryfin
force-pushed
the
adr-publish-chart-to-rancher
branch
from
b15f5bc to
209344a
Compare
Signed-off-by: Carlos Salas <[email protected]>
salasberryfin
force-pushed
the
adr-publish-chart-to-rancher
branch
from
209344a to
27d2f7a
Compare
|
CI is now fixed and the ADR is ready for a final review. |
furkatgofurov7
approved these changes
Mar 18, 2024
Danil-Grigorev
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This ADR puts together details of the two main options for serving Helm charts:
The idea is that we go over the pros/cons as a team and try to decide which is the best option and define an action plan, if necessary.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist: