Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add devcontainer #434

Merged
merged 2 commits into from
Mar 18, 2024
Merged

feat: add devcontainer #434

merged 2 commits into from
Mar 18, 2024

Conversation

richardcase
Copy link
Contributor

What this PR does / why we need it:

Adding a devcontainer that can be used to give a reproducible environment. This has been tested with the e2e tests.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Adding a devcontainer that can be used to give a reproducible
environment. This has been tested with the e2e tests.

Signed-off-by: Richard Case <[email protected]>
salasberryfin
salasberryfin previously approved these changes Mar 15, 2024
@furkatgofurov7
Copy link
Contributor

@richardcase let's have it also in the CAPRKE2 provider.

@richardcase richardcase merged commit 1527ae7 into rancher:main Mar 18, 2024
11 checks passed
@richardcase richardcase deleted the devcontainer branch March 18, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants