updating reboot logic to minimize the chance of an unnecessary reboot #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mddamato
approved these changes
Apr 12, 2024
aleiner
deleted the
199-re-evaluate-the-necessity-to-reboot-a-node-after-making-sysctl-changes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing code would reboot a server at install time due to sysctl changes. It turns out that a reboot is only necessary if RKE2 is already running.
What type of PR is this?
What this PR does / why we need it:
Updates the reboot logic to check to see if RKE2 is running. If it is, and sysctl updates, reboot the host. Otherwise just restart sysctl.
Which issue(s) this PR fixes:
Fixes #199
Release Notes
NONE