Added LED blink functionality #485
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 25, 2024 08:25
options for BREW LED and STATUS LED
|
Would you please run the "Custom > Apply clang-format" target in PlatformIO so the checks go through? Thanks! |
|
I have updated the files in clang-format. Thanks for the hint |
LoQue90
reviewed
Aug 18, 2024
| #define FEATURE_STATUS_LED_TYPE 1 // 1 = Turn on status LED when temp is in range - otherwise off, 2 = Turn on status LED when temp is in range - otherwise blinking | ||
| #define FEATURE_BREW_LED 0 // Turn on brew LED when brew is started, 0 = deactivated, 1 = activated, 2 = blink | ||
| #define FEATURE_BREW_LED_TYPE \ | ||
| 1 // 1 = Turn on brew LED when brew is started, 2 = Blink brew LED when brew is started#define LED_TYPE LED::STANDARD // STANDARD_LED for an LED connected to a GPIO pin, WS2812 for adressable LEDs |
|
in my opinion, this is something that should be configurable from the website and not in the userconfig. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New proposal incorporating PeriodicTrigger and updated macro structure based on feedback received
This change allows blinking functionality for status LED and brew LED.