Merge pull request #314 from range-of-motion/313-fix-not-being-able-t…

…o-view-budgets-page-after-deleting-tag

Fix not being able to view budgets page after deleting tag

app/Models/Tag.php

@@ -23,6 +23,11 @@ class Tag extends Model
     ];
 
     // Relations
+    public function budgets()
+    {
+        return $this->hasMany(Budget::class);
+    }
+
     public function spendings()
     {
         return $this->hasMany(Spending::class);

database/migrations/2021_06_23_200708_delete_budgets_without_tags.php

@@ -0,0 +1,26 @@
+<?php
+
+use App\Models\Budget;
+use App\Models\Tag;
+use Illuminate\Database\Migrations\Migration;
+use Illuminate\Database\Schema\Blueprint;
+use Illuminate\Support\Facades\Schema;
+
+class DeleteBudgetsWithoutTags extends Migration
+{
+    public function up(): void
+    {
+        foreach (Budget::all() as $budget) {
+            $hasStrayTag = $budget->tag_id && !$budget->tag;
+
+            if ($hasStrayTag) {
+                $budget->delete();
+            }
+        }
+    }
+
+    public function down(): void
+    {
+        //
+    }
+}

resources/views/tags/index.blade.php

@@ -33,7 +33,7 @@
                                 </a>
                             </div>
                             <div class="row__column row__column--compact ml-2">
-                                @if ($tag->spendings->count())
+                                @if ($tag->budgets->count() || $tag->spendings->count())
                                     <i class="fas fa-trash-alt"></i>
                                 @else
                                     <form method="POST" action="/tags/{{ $tag->id }}">