Add Recog support for LDAP searchResponse and encoded examples #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -54,6 +54,15 @@ tests that `RomSShell_4.62` matches the provided regular expression and that the | |||
|
|
|||
| The `param` elements contain a `pos` attribute, which indicates what capture field from the `pattern` should be extracted, or `0` for a static string. The `name` attribute is the key that will be reported in the case of a successful match and the `value` will either be a static string for `pos` values of `0` or missing and taken from the captured field. | |||
|
|
|||
| The `example` string can be base64 encoded to permit the use of unprintable characters. To signal this to Recog an `_encoding` attribute with the value of `base64` is added to the `example` element. Based64 encoded text that is longer than 80 characters should be wrapped as shown below. | |||
There was a problem hiding this comment.
This 80-character wrapping is a suggestion rather than a requirement, right?
There was a problem hiding this comment.
Yes, as far as I know there are no technical requirements for wrapping the lines. I've tested with one line that was 170 chars and it passed validation.
There was a problem hiding this comment.
OK, thats what I thought. Maybe tweak this wording a bit to make it clear that this is not required but suggested for readability/maintenance.
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!-- | ||
| Notes: Ruby will fail to build the RegExp if it contains \x84 which is a standard | ||
| byte in ANS.1 Sequence length fields. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for parsing the binary LDAP searchResponse banner. There are 55 new fingerprints with 68 total tests.
It also adds the
_encodingattribute toexamplefingerprint elements to allow example strings to be base64 encoded.For example: