-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POC for #75 #83
Closed
Closed
POC for #75 #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just a test for now. If/when this gets released, we'll need to bump to 3.x
Also update all unit tests/etc to not use flags
This reverts commit a10fdb8.
7 tasks
Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now this is just a POC for the second proposed solution in #75. Basically I am proposing that we do away with the
flags
attribute entirely and utilize special grouping or non-grouping constructs as necessary to provide equivalent functionality. So, for example instead ofpattern="foo" flags="REG_ICASE"
, we will usepattern="(?i:foo)"
.There are basically 3 parts to this PR:
fingerprints
to the new formatflags
To merge this, at a minimum we'd need to bump to 3.x and any projects that utilize recog will need to ensure that their usage of the Recog content properly handles these new regular expressions.