Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC for #75 #83

Closed
wants to merge 23 commits into from
Closed

POC for #75 #83

wants to merge 23 commits into from

Conversation

jhart-r7
Copy link
Contributor

Right now this is just a POC for the second proposed solution in #75. Basically I am proposing that we do away with the flags attribute entirely and utilize special grouping or non-grouping constructs as necessary to provide equivalent functionality. So, for example instead of pattern="foo" flags="REG_ICASE", we will use pattern="(?i:foo)".

There are basically 3 parts to this PR:

  1. Write a utility to convert only affected fingerprints to the new format
  2. Convert the existing XML fingerprint files
  3. Remove all code related to parsing of flags

To merge this, at a minimum we'd need to bump to 3.x and any projects that utilize recog will need to ensure that their usage of the Recog content properly handles these new regular expressions.

@jhart-r7
Copy link
Contributor Author

Closing for now.

@jhart-r7 jhart-r7 closed this Jul 27, 2016
@jhart-r7 jhart-r7 deleted the bug/75-regexp-flags branch October 10, 2018 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant