-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
De-vendor CMake dependencies and use shared libraries #753
base: branch-24.12
Are you sure you want to change the base?
Conversation
/ok to test |
Thanks Gigon! 🙏 Moved this to 24.10. Hope that is ok 🙂 |
/ok to test |
2 similar comments
/ok to test |
/ok to test |
In conda-forge this is called Though I wonder if we want to use rapids-cmake's |
/ok to test |
1 similar comment
/ok to test |
cuLIBOS is a static library that is included as part of CUDART and installed with the NVCC compiler In terms of finding it, CMake already has FindCUDAToolkit, which includes a So we can probably drop this file and simplify associated logic |
/ok to test |
@jakirkham It looks like the build container is out of space. https://github.com/rapidsai/cucim/actions/runs/10206351504/job/28239540987?pr=753
|
Do we know how much space we are using? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we just need Boost headers, we can make this change
/ok to test |
Style check failure is due to a small typo. Fixing in PR: #759 |
7a66c5e
to
924aa0a
Compare
Rebased Edit: Hoped that would mean GitHub would sign all the commits for us, but it seems that didn't work |
We discussed this PR in the cuCIM meeting and decided this wasn't going to make 24.10. So have moved to 24.12 |
#785 (comment) for devendoring libtiff |
Signed-off-by: Gigon Bae <[email protected]>
Signed-off-by: Gigon Bae <[email protected]>
Signed-off-by: Gigon Bae <[email protected]>
Signed-off-by: Gigon Bae <[email protected]>
Signed-off-by: Gigon Bae <[email protected]>
Signed-off-by: Gigon Bae <[email protected]>
Signed-off-by: Gigon Bae <[email protected]>
Signed-off-by: Gigon Bae <[email protected]>
Signed-off-by: Gigon Bae <[email protected]>
Signed-off-by: Gigon Bae <[email protected]>
Signed-off-by: Gigon Bae <[email protected]>
Remove workarounds that address the following errors: Use generator expression to avoid `nvcc fatal : Value '-std=c++17' is not defined for option 'Werror'` Signed-off-by: Gigon Bae <[email protected]>
Do not use catch_discover_tests() since it causes a test to be run at build time and somehow it causes a deadlock during the build. Signed-off-by: Gigon Bae <[email protected]>
Signed-off-by: Gigon Bae <[email protected]>
Signed-off-by: Gigon Bae <[email protected]>
Signed-off-by: Gigon Bae <[email protected]>
Signed-off-by: Gigon Bae <[email protected]>
Signed-off-by: Gigon Bae <[email protected]>
Signed-off-by: Gigon Bae <[email protected]>
Signed-off-by: Gigon Bae <[email protected]>
Signed-off-by: Gigon Bae <[email protected]>
Signed-off-by: Gigon Bae <[email protected]>
Signed-off-by: Gigon Bae <[email protected]>
Signed-off-by: Gigon Bae <[email protected]>
It looks like the RAPIDS CI/CD is launching the docker container with a reduced shared memory size. This is causing the shared memory cache to be failed with 'RuntimeError: No space left on device'. Signed-off-by: Gigon Bae <[email protected]>
This patch de-vendors CMake dependencies and use/link shared libraries as much as possible.
Devendor CMake dependencies #686
Switch to build with CXX11 ABI because we are now building manylinux_2_28 wheel.
_GLIBCXX_USE_CXX11_ABI=0
because manylinux2014 requires gcc4-compatible libstdcxx-abi(gcc is configured with '--with-default-libstdcxx-abi=gcc4-compatible', https://gcc.gnu.org/onlinedocs/libstdc++/manual/configure.html) which forces to set_GLIBCXX_USE_CXX11_ABI=0
sostd::pmr::string
wouldn't be available on CentOS 7.Update
tests/unit/clara/test_image_cache.py::test_get_shared_memory_cache
to reduce the shared memory size.FAILED tests/unit/clara/test_image_cache.py::test_get_shared_memory_cache - RuntimeError: No space left on device
Tasks
CONDA_PREFIX
environment variable is not available).Added conda packages (for build)
Test procedure
using docker
using conda locally