address review, and remove xfail from polars test

rapidsai · Nov 8, 2024 · a56d5fc · a56d5fc
1 parent 40579f5
commit a56d5fc
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/python/cudf_polars/cudf_polars/testing/asserts.py b/python/cudf_polars/cudf_polars/testing/asserts.py
@@ -121,7 +121,9 @@ def assert_ir_translation_raises(q: pl.LazyFrame, *exceptions: type[Exception])
     translator.translate_ir()
     if errors := translator.errors:
         for err in errors:
-            assert any(isinstance(err, err_type) for err_type in exceptions)
+            assert any(
+                isinstance(err, err_type) for err_type in exceptions
+            ), f"Translation DID NOT RAISE {exceptions}"
         return
     else:
         raise AssertionError(f"Translation DID NOT RAISE {exceptions}")

diff --git a/python/cudf_polars/cudf_polars/testing/plugin.py b/python/cudf_polars/cudf_polars/testing/plugin.py
@@ -45,7 +45,6 @@ def pytest_configure(config: pytest.Config) -> None:
 
 
 EXPECTED_FAILURES: Mapping[str, str] = {
-    "tests/unit/dataframe/test_df.py::test_extension": "AssertionError",
     "tests/unit/io/test_csv.py::test_compressed_csv": "Need to determine if file is compressed",
     "tests/unit/io/test_csv.py::test_read_csv_only_loads_selected_columns": "Memory usage won't be correct due to GPU",
     "tests/unit/io/test_lazy_count_star.py::test_count_compressed_csv_18057": "Need to determine if file is compressed",