-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit runtime dependency to libarrow>=16.0.0,<16.1.0a0
#15782
Limit runtime dependency to libarrow>=16.0.0,<16.1.0a0
#15782
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run-exports were recently fixed on conda-forge and should save us here. This was done less than 12 hours ago so a rebuild of nightlies across RAPIDS should fix it.
Fix for 16.1: conda-forge/arrow-cpp-feedstock#1409
Backport of this fix to 16.0: conda-forge/conda-forge-repodata-patches-feedstock@6155ba0
That doesn’t seem to do the trick, build is picking up the latest release:
still fails: ImportError: libarrow.so.1600: cannot open shared object file: No such file or directory Latest build is |
Summarizing some conversations from other places... in short, the root cause for the error reported in this PR's description is the mix of the following: *
The ideal fix for this is to update the run exports for conda-forge's To hopefully unblock
|
It looks to me like this fixes the libarrow issue... I see But the Python tests appear to still be failing with the other, Dask-related issue @rjzamora is working on in #15788.
So @vyasr @bdice @pentschev @rjzamora I think we'll either need to admin merge this or decide on one PR (#15788 or this one) to fix both issues at the same time. |
# TODO: start taking libarrow's run exports again wwhen they're correct for 16.0 | ||
# ref: https://github.com/conda-forge/arrow-cpp-feedstock/issues/1418 | ||
- libarrow>=16.0.0,<16.1.0a0 | ||
- libarrow-acero>=16.0.0,<16.1.0a0 | ||
- libarrow-dataset>=16.0.0,<16.1.0a0 | ||
- libparquet>=16.0.0,<16.1.0a0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the libarrow
pin sufficient? The rest are pinned exactly to it (for example)
# TODO: start taking libarrow's run exports again wwhen they're correct for 16.0 | |
# ref: https://github.com/conda-forge/arrow-cpp-feedstock/issues/1418 | |
- libarrow>=16.0.0,<16.1.0a0 | |
- libarrow-acero>=16.0.0,<16.1.0a0 | |
- libarrow-dataset>=16.0.0,<16.1.0a0 | |
- libparquet>=16.0.0,<16.1.0a0 | |
# TODO: start taking libarrow's run exports again wwhen they're correct for 16.0 | |
# ref: https://github.com/conda-forge/arrow-cpp-feedstock/issues/1418 | |
- libarrow>=16.0.0,<16.1.0a0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're probably right that it would be enough. I went for all of them just mimicking what I already saw in dependencies.yaml
here for building the test environment.
Alright if we still merge this, and then I push a follow-up PR trying to pare this back down to just libarrow
? That way we wouldn't have to wait for another CI cycle to get the fix onto branch-24.06
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's worth changing at this point. Once the upstream arrow packages are updated we'll just be dropping this altogether anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok works for me, I won't touch this unless @jakirkham disagrees and thinks we should pursue it.
Fix
libarrow
runtime dependency which is currently broken due to the release oflibarrow=16.1.0
: