Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build wheels without build isolation #17088

Merged
merged 11 commits into from
Oct 28, 2024
Merged

build wheels without build isolation #17088

merged 11 commits into from
Oct 28, 2024

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Oct 15, 2024 •
edited
Loading

Description

Contributes to rapidsai/build-planning#108
Contributes to rapidsai/build-planning#111

Proposes some small packaging/CI changes, matching similar changes being made across RAPIDS.

  • building libcudf wheels with --no-build-isolation (for better sccache hit rate)
  • printing sccache stats to CI logs
  • updating to the latest rapids-dependency-file-generator (v1.16.0)
  • always explicitly specifying cpp / python in calls to rapids-upload-wheels-to-s3

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jameslamb jameslamb added 5 - DO NOT MERGE Hold off on merging; see PR for details improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 15, 2024
@github-actions github-actions bot added the Python Affects Python cuDF API. label Oct 15, 2024
@jameslamb jameslamb mentioned this pull request Oct 15, 2024
Closed
@github-actions github-actions bot added the cudf.polars Issues specific to cudf.polars label Oct 15, 2024
@jameslamb jameslamb mentioned this pull request Oct 22, 2024
Closed
@github-actions github-actions bot removed Python Affects Python cuDF API. cudf.polars Issues specific to cudf.polars labels Oct 23, 2024
@jameslamb jameslamb changed the title WIP: [DO NOT MERGE] build wheels without build isolation build wheels without build isolation Oct 28, 2024
@jameslamb jameslamb removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Oct 28, 2024
@jameslamb jameslamb requested a review from bdice October 28, 2024 16:56
@jameslamb jameslamb marked this pull request as ready for review October 28, 2024 16:56
@jameslamb jameslamb requested review from a team as code owners October 28, 2024 16:56
@jameslamb jameslamb requested a review from vyasr October 28, 2024 18:46
@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit abecd0b into rapidsai:branch-24.12 Oct 28, 2024
113 checks passed
@jameslamb jameslamb deleted the wheel-build-no-isolation branch October 28, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@vyasr vyasr Awaiting requested review from vyasr

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
cuDF Python
Status: Done
cuDF/Dask/Numba/UCX
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jameslamb @bdice