Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose streams in public quantile APIs #17257

Open
wants to merge 7 commits into
base: branch-24.12
Choose a base branch
from
Open

Expose streams in public quantile APIs #17257

wants to merge 7 commits into from
+88 −10

Conversation

shrshi
Copy link
Contributor

@shrshi shrshi commented Nov 6, 2024

Description

Adds stream parameter to

cudf::quantile
cudf::quantiles
cudf::percentile_approx

Added stream gtests to verify correct stream forwarding.

Reference: #13744

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Nov 6, 2024
@shrshi shrshi mentioned this pull request Nov 6, 2024
Open
@shrshi shrshi added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 6, 2024
@shrshi shrshi marked this pull request as ready for review November 6, 2024 18:57
@shrshi shrshi requested a review from a team as a code owner November 6, 2024 18:57
davidwendt
davidwendt requested changes Nov 7, 2024
View reviewed changes
cpp/tests/streams/quantile_test.cpp Outdated Show resolved Hide resolved
cpp/include/cudf/quantiles.hpp Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt requested changes

@pmattione-nvidia pmattione-nvidia pmattione-nvidia approved these changes

@kingcrimsontianyu kingcrimsontianyu Awaiting requested review from kingcrimsontianyu kingcrimsontianyu is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Requested changes must be addressed to merge this pull request.

Assignees

@shrshi shrshi

Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
cuDF/Dask/Numba/UCX
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shrshi @davidwendt @pmattione-nvidia