-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize distinct inner join to use set find
instead of retrieve
#17278
Draft
PointKernel
wants to merge
5
commits into
rapidsai:branch-24.12
Choose a base branch
from
PointKernel:improve-distinct-inner-join
base: branch-24.12
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Optimize distinct inner join to use set find
instead of retrieve
#17278
PointKernel
wants to merge
5
commits into
rapidsai:branch-24.12
from
PointKernel:improve-distinct-inner-join
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PointKernel
added
libcudf
Affects libcudf (C++/CUDA) code.
Performance
Performance related issue
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
labels
Nov 8, 2024
Performance comparison with RTX8000
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
improvement
Improvement / enhancement to an existing function
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
Performance
Performance related issue
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a minor optimization for distinct inner joins by using the
find
results to selectively copy matches to the output. This approach eliminates the need for the costlyretrieve
operation, which relies on expensive atomic operations.Checklist