-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enforce cmake-format
and cmake-lint
, other small packaging changes
#111
Conversation
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
/ok to test |
cmake-format
and cmake-lint
, other small packaging changescmake-format
and cmake-lint
, other small packaging changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems good :)
Thank you both! |
/merge |
Part of rapidsai/build-planning#136, which tracks some building/packaging simplifications and conventions we'd like to standardize across RAPIDS.
This proposes the following:
cmake-format
to autoformat CMake codecmake-lint
to enforce style preferences for CMake code-DDETECT_CONDA_ENV
for wheel buildsgha-tools
things handling wheelsNotes for Reviewers
The
cmake-format
/cmake-lint
approach was copied directly from RAFT:Other RAPIDS projects (like cuDF) do this the same way.
All formatting-only changes to CMake in this PR were made automatically by
cmake-foramt
.