Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enforce cmake-format and cmake-lint, other small packaging changes #111

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

jameslamb
Copy link
Member

Part of rapidsai/build-planning#136, which tracks some building/packaging simplifications and conventions we'd like to standardize across RAPIDS.

This proposes the following:

  • using cmake-format to autoformat CMake code
  • using cmake-lint to enforce style preferences for CMake code
  • removing unnecessary use of -DDETECT_CONDA_ENV for wheel builds
  • explicitly passing package type to GitHub Actions / gha-tools things handling wheels

Notes for Reviewers

The cmake-format / cmake-lint approach was copied directly from RAFT:

Other RAPIDS projects (like cuDF) do this the same way.

All formatting-only changes to CMake in this PR were made automatically by cmake-foramt.

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jan 22, 2025
Copy link

copy-pr-bot bot commented Jan 22, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@jameslamb
Copy link
Member Author

/ok to test

@jameslamb jameslamb changed the title WIP: enforce cmake-format and cmake-lint, other small packaging changes enforce cmake-format and cmake-lint, other small packaging changes Jan 22, 2025
@jameslamb jameslamb requested a review from linhu-nv January 22, 2025 21:06
@jameslamb jameslamb marked this pull request as ready for review January 22, 2025 21:06
@jameslamb jameslamb requested review from a team as code owners January 22, 2025 21:06
@jameslamb jameslamb requested a review from gforsyth January 22, 2025 21:06
Copy link

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@linhu-nv linhu-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good :)

@jameslamb
Copy link
Member Author

Thank you both!

@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit f6e3654 into rapidsai:branch-25.02 Jan 23, 2025
84 checks passed
@jameslamb jameslamb deleted the cmake-formatting branch January 23, 2025 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants