Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract the edgelist from the graph #4750

Open
wants to merge 11 commits into
base: branch-24.12
Choose a base branch
from

Conversation

jnke2016
Copy link
Contributor

@jnke2016 jnke2016 commented Nov 9, 2024

This PR exposes the C++ function decompress_to_edgelist to the C, PLC and Python API. This will enable the extraction of the edgelist from a graph which is currently not supported.

@jnke2016 jnke2016 requested review from a team as code owners November 9, 2024 09:35
@jnke2016 jnke2016 changed the title extract edgelist from the graph extract the edgelist from the graph Nov 9, 2024
@jnke2016 jnke2016 self-assigned this Nov 15, 2024
@jnke2016 jnke2016 added this to the 24.12 milestone Nov 15, 2024
@@ -979,6 +980,83 @@ def convert_to_cudf(cp_arrays):

return ddf

def decompress_to_edgelist(
self,
original: bool = True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be more descriptive if it was named return_unrenumbered_edgelist


Returns
-------
ego_edge_lists : dask_cudf.DataFrame
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the right name for the return value? Also, should it be plural? I figured it would be just edgelist

Comment on lines +96 to +98
>>> (sources, destinations, edge_weights, _, _) =
... pylibcugraph.induced_subgraph(
... resource_handle, G, False)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be calling decompress_to_edgelist somewhere?

@@ -979,6 +980,83 @@ def convert_to_cudf(cp_arrays):

return ddf

def decompress_to_edgelist(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only see this on the MG Graph API, shouldn't this also be added to the SG Graph API?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants