heterogeneous sampling primitive #4836
Merged
+6,146
−3,206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to fea_prim_heterogeneous_sampling_prim
…to fea_prim_heterogeneous_sampling_prim
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
…to fea_prim_heterogeneous_sampling_prim
seunghwak
changed the title
…to fea_prim_heterogeneous_sampling_prim
seunghwak
added
improvement
ChuckHastings
approved these changes
Jan 31, 2025
|
To be clear... this PR updates the primitive. But the sampling algorithm is not modified in this PR to use the primitive. We will need to add work in 25.04 to use this primitive, correct? |
…to fea_prim_heterogeneous_sampling_prim
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently use edge masking for heterogeneous sampling. This is inefficient as we need scan the entire edges # edge types times every time we call a sampling function.
This PR fixes this. We extract a subgraph (seeds and their neighbors) with edge types. Then, we perform sampling on this subgraph so no need to scan the entire edge.
This PR also updated
cugraph::test::mg_graph_to_sg_graphfunction to support edge types (which is necessary to test this primitive). A large number of files (in the test directory) are modified due to this change, but updates are just few lines for each file.Closes #4735
Closes #4590