-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix shuffle comm operators with no default constructors #4869
Open
caugonnet
wants to merge
2
commits into
rapidsai:branch-25.02
Choose a base branch
from
caugonnet:fix_shuffle_comm_operators_v2
base: branch-25.02
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix shuffle comm operators with no default constructors #4869
caugonnet
wants to merge
2
commits into
rapidsai:branch-25.02
from
caugonnet:fix_shuffle_comm_operators_v2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instantiate using lambda functions. These lambda functions may have capture lists so that there is no default constructor, and we cannot call the default constructor of this operator.
/ok to test |
ChuckHastings
added
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
labels
Jan 23, 2025
Do we still need this once #4888 gets merged? |
I guess with #4888 the constructors are implicit ... I haven't check if all classes have been modified |
Can we close this in favor of #4888 |
With #4888 merged, can we close this or is there something remaining to do? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cuGraph
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Operators such as key_group_id_less_t are templated by functors which we instantiate using lambda functions. These lambda functions may have capture lists so that there is no default constructor, and we cannot call the default constructor of this operator.
This solves the following errors :