New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropping CMake install in ARM wheel tests? #6023

Open

jakirkham opened this issue Aug 14, 2024 · 1 comment · May be fixed by #6190

Member

jakirkham commented Aug 14, 2024

It looks like we install CMake in the ARM wheel tests for cuML. This was added in PR: #5507

cuml/ci/test_wheel.sh

Lines 10 to 13 in 990db71

    
           # On arm also need to install CMake because treelite needs to be compiled (no wheels available for arm). 
        
           if [[ "$(arch)" == "aarch64" ]]; then 
        
               python -m pip install cmake 
        
           fi

The comment here mentions building Treelite from source. However looking at a recent CI log, it appears we just download Treelite binaries

Given this, can we drop this workaround? Or is there more context?

Member

dantegd commented Aug 15, 2024

I think it should be totally fine now, that predates availability of ARM treelite packages indeed.

jameslamb linked a pull request

that will close this issue

simplify wheel CI scripts, other small packaging changes #6190

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment