-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simplify wheel CI scripts, other small packaging changes #6190
base: branch-25.02
Are you sure you want to change the base?
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
/ok to test |
/ok to test |
dependencies.yaml
Outdated
@@ -142,9 +173,7 @@ dependencies: | |||
- cxx-compiler | |||
- fmt>=11.0.2,<12 | |||
- libcumlprims==25.2.*,>=0.0.0a0 | |||
- libcuvs==25.2.*,>=0.0.0a0 | |||
- libraft-headers==25.2.*,>=0.0.0a0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could move/remove libcumlprims
and libraft-headers
into their own depends_on_X
lists. Or maybe we can remove libraft-headers
here? We did that in cugraph, iirc. This is not a blocker, I defer to your judgment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we want to remove libraft-headers
here. That was fine in rapidsai/cugraph#4805 (comment) because there, it was coming through transitively via libraft
.
cuml
's environments and conda recipes don't depend on libraft
, so I think it's still needed here.
I just pushed b9a0bb0 moving libcumlprims
and libraft-headers
into depends_on lists. They were only used once so it doesn't remove any duplication today, but it's helpful for applying this depends_on convention consistently across RAPIDS, and keeps the diff of a future change using those packages in more places smaller.
I'll merge this once CI passes.
4d51566
to
b9a0bb0
Compare
Fixes #6023
Proposes some miscellaneous packaging cleanup:
rapids-dependency-file-generator
to its latest version (1.17.0) in pre-commit configPACKAGE_CUDA_SUFFIX
inbuild_wheel.sh
pip install cmake
intest_wheel.sh
treelite
wheels now: https://pypi.org/project/treelite/#filesBUILD_PRIMS_BENCH OFF
, removesBUILD_BENCH OFF
inget_raft.cmake
(matching changes to RAFT from 23.04: Add end-to-end CUDA ann-benchmarks to raft raft#1304)BUILD_CUML_PRIMS_BENCH
(nothing uses this)CUML_USE_FAISS_STATIC
(nothing uses this)dependencies.yaml
changes:depends_on_*
groups to reduce duplication, and for consistency with other RAPIDS projects (docs explaining this)