Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SVM cpu/gpu interop #6089

Open
wants to merge 14 commits into
base: branch-25.02
Choose a base branch
from
Open

SVM cpu/gpu interop #6089

wants to merge 14 commits into from

Conversation

viclafargue
Copy link
Contributor

No description provided.

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 30, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the Cython / Python Cython or Python issue label Sep 30, 2024
@dantegd dantegd mentioned this pull request Oct 4, 2024
Open
@viclafargue viclafargue changed the base branch from branch-24.10 to branch-24.12 November 22, 2024 18:34
@viclafargue viclafargue marked this pull request as ready for review December 3, 2024 16:17
@viclafargue viclafargue requested a review from a team as a code owner December 3, 2024 16:17
betatim
betatim reviewed Dec 4, 2024
View reviewed changes
Copy link
Member

@betatim betatim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a first look at the PR and most of my comments are about why things are the way they are. In particular the CPUModel class.

python/cuml/cuml/svm/svc.pyx Outdated Show resolved Hide resolved
python/cuml/cuml/svm/svc.pyx Outdated Show resolved Hide resolved
python/cuml/cuml/svm/svc.pyx Outdated Show resolved Hide resolved
python/cuml/cuml/svm/svc.pyx Show resolved Hide resolved
python/cuml/cuml/svm/svc.pyx Show resolved Hide resolved
python/cuml/cuml/svm/svc.pyx Show resolved Hide resolved
python/cuml/cuml/tests/test_device_selection.py Outdated Show resolved Hide resolved
@viclafargue viclafargue requested review from a team as code owners December 11, 2024 17:07
@viclafargue viclafargue changed the base branch from branch-24.12 to branch-25.02 December 11, 2024 17:07
@viclafargue
Copy link
Contributor Author

Added SVC estimator to the documentation as it appears that it was missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betatim betatim betatim left review comments

@csadorf csadorf Awaiting requested review from csadorf csadorf is a code owner automatically assigned from rapidsai/cuml-python-codeowners

@msarahan msarahan Awaiting requested review from msarahan msarahan was automatically assigned from rapidsai/packaging-codeowners

@dantegd dantegd Awaiting requested review from dantegd dantegd was automatically assigned from rapidsai/cuml-cmake-codeowners

@cjnolet cjnolet Awaiting requested review from cjnolet cjnolet was automatically assigned from rapidsai/cuml-cmake-codeowners

At least 1 approving review is required to merge this pull request.

Assignees

@viclafargue viclafargue

Labels
cuml-cpu Cython / Python Cython or Python issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@viclafargue @betatim @dantegd