Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remap BATCH_TREE_REORG to TREE_REORG in FIL #6161

Open
wants to merge 5 commits into
base: branch-25.02
Choose a base branch
from

Conversation

wphicks
Copy link
Contributor

@wphicks wphicks commented Dec 5, 2024

Avoid a bug which causes a batch of trees in the BATCH_TREE_REORG implementation to be labeled as complete (all having reached leaf nodes) when they are not. In the best case, this causes a crash when invalid shared memory is accessed. In the worst case, trees will silently contribute incorrect values to the final output.

This workaround simply disables BATCH_TREE_REORG by remapping BATCH_TREE_REORG to TREE_REORG in the C++ layer. The fundamental issue should be fixed through promotion of experimental FIL to default.

Avoid a bug which causes a batch of trees in the BATCH_TREE_REORG implementation to be labeled as complete (all having reached leaf nodes) when they are not. In the best case, this causes a crash when invalid shared memory is accessed. In the worst case, trees will silently contribute incorrect values to the final output.

This workaround simply disables BATCH_TREE_REORG by remapping BATCH_TREE_REORG to TREE_REORG in the C++ layer. The fundamental issue should be fixed through promotion of experimental FIL to default.
@github-actions github-actions bot added conda conda issue Cython / Python Cython or Python issue labels Dec 6, 2024
@wphicks wphicks added bug Something isn't working non-breaking Non-breaking change and removed conda conda issue Cython / Python Cython or Python issue labels Dec 6, 2024
@wphicks wphicks marked this pull request as ready for review December 6, 2024 13:58
@wphicks wphicks requested review from a team as code owners December 6, 2024 13:58
@github-actions github-actions bot added conda conda issue Cython / Python Cython or Python issue labels Dec 6, 2024
@github-actions github-actions bot removed the conda conda issue label Dec 6, 2024
@wphicks
Copy link
Contributor Author

wphicks commented Dec 19, 2024

/merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CUDA/C++ Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants