-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use rapids-logger to generate the cuml logger #6162
Merged
Merged
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
ae34b8f
Remove old loggers
vyasr 0db46a1
Switch over to new logger and update all code to use the new enums (s…
vyasr 53262f7
Stop changing pattern unnecessarily
vyasr a007134
Get C++ compiling
vyasr 91c8e83
Switch to using new repo
vyasr f4fad02
Update to use the new functionality
vyasr c898c29
Get Python code compiling
vyasr 4a3a18c
Ensure new level_enum is used everywhere it should be to specify log …
vyasr 68ad0bd
Ensure that verbosity is consistently set using the level_enum
vyasr ee7e376
Fix some docstrings
vyasr 81ba843
Fix one logger test
vyasr 4e63f7d
Fix compilation of cuml-cpu
vyasr e6a9898
Enable flushing
vyasr 69e2bec
Revert all pure Python changes
vyasr 34d79da
Revert changes to public APIs and docstrings in Cython
vyasr fa77a86
Revert remaining changes and update base class for verbosity compatib…
vyasr 0826775
Fix inversion of log levels
vyasr bcc766c
Rewrite verbosity on access instead of on save to appease sklearn checks
vyasr b9ca57d
Appease linter
vyasr 0e7bbd2
Fix typing
vyasr e99cbcf
Turn of shallow clones
vyasr 74c5f36
Also set the flush for the C++ test
vyasr ed428be
Fix setting of default logging level
vyasr 1255885
Fix C++ flushing test
vyasr 9a2fd45
Merge remote-tracking branch 'upstream/branch-25.02' into feat/logger
vyasr 9ff2c0a
Try using a custom descriptor
vyasr 8d8561d
Fix behavior of VerboseDescriptor
wphicks 62895f0
Correct verbose handling in set_params
wphicks ae32097
Fix a couple of bugs in umap behavior
vyasr fab6638
Merge remote-tracking branch 'upstream/branch-25.02' into feat/logger
vyasr 0e4a2e9
Merge remote-tracking branch 'upstream/branch-25.02' into feat/logger
vyasr d238f1e
Fix logger call to use commit hash
vyasr 2cbbaca
Fix repo
vyasr 0ee209f
Merge branch 'branch-25.02' into feat/logger
vyasr 5b66f08
style
vyasr 64f80f9
Fix lbfgs test verifying log level
vyasr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I presume this is something that happens in all repos that use rapids-logger, I wonder if a function in rapids-cmake would be a good idea instead of using CPMAddPackage directly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes absolutely. Every repository will have to do its own call to
rapids_make_logger
to provide the right arguments, but I plan to replace theCPMAddPackage
call with a rapids-cmake call. I will do that a bit later though once I'm ready to synchronize all the repos because right now they are using different commit hashes and I'll be adding a couple more features to the trunk of rapids-logger before I synchronize all the repos using it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Starting to address this in rapidsai/rapids-cmake#737.