HDBSCAN and KMeans API improvements for improving CPU interoperability #6181
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
dantegd
changed the title
dantegd
changed the title
dantegd
added
improvement
DOC comment explaining behavior
| self._gen_min_span_tree = \ | ||
| GlobalSettings().accelerator_active or value |
There was a problem hiding this comment.
In general we should not set attributes to values that are different from the constructor argument.
I tried to work out why doing this increases compatibility, but couldn't the default of gen_min_span_tree in HDBSCAN is also False. What was the thinking for making this default on when the accelerator is enabled?
There was a problem hiding this comment.
Over-zealousness of wanting the mst to be available always when I was testing locally, forgot that the original hdbscan package has the same gen_min_span_tree parameter, so I removed this logic :)
|
/merge |
No description provided.