Update for raft logger changes #6187
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
improvement
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
…s reexporting cuvs types that depend on raft types.
|
/ok to test |
|
/ok to test |
vyasr
force-pushed
the
feat/raft_logger
branch
from
b634612 to
9824b26
Compare
|
/ok to test |
1 similar comment
|
/ok to test |
|
/ok to test |
vyasr
commented
Dec 19, 2024
ci/build_cpp.sh
Outdated
There was a problem hiding this comment.
Changes are for testing, will be removed before merge.
ci/build_python.sh
Outdated
There was a problem hiding this comment.
Changes are for testing, will be removed before merge.
cpp/cmake/thirdparty/get_cuvs.cmake
Outdated
There was a problem hiding this comment.
Changes are for testing, will be removed before merge.
cpp/cmake/thirdparty/get_raft.cmake
Outdated
There was a problem hiding this comment.
Changes are for testing, will be removed before merge.
|
/ok to test |
bdice
reviewed
Dec 19, 2024
bdice
approved these changes
Dec 19, 2024
Co-authored-by: Bradley Dice <[email protected]>
bdice
approved these changes
Dec 19, 2024
vyasr
force-pushed
the
feat/raft_logger
branch
from
0f52d95 to
e65e48b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates cuml to use raft's updated logger implementation using rapids-logger.
This PR requires rapidsai/cuvs#540 (cuml requires both raft and cuvs updates).
Contributes to rapidsai/build-planning#104