-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Python 3.12 support, prefer absolute paths in Dockerfiles #102
Conversation
@@ -31,7 +31,7 @@ RUN cat /dask.yml \ | |||
| sed -r "s/pyarrow=/pyarrow>=/g" \ | |||
| sed -r "s/pandas=/pandas>=/g" \ | |||
| sed -r "s/numpy=/numpy>=/g" \ | |||
> dask_unpinned.yml | |||
> /dask_unpinned.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right below, this is referenced as /dask_unpinned.yml
(absolute path).
That means this has only been working because the working directory happens to be /
. Making this an absolute path just makes this a little safer, in case that working directory is changed in the base image in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @jameslamb .
Thanks @jameslamb! Just kicked off a rebuild of the image matrix (you should be able to see the status of all runs here) |
Contributes to rapidsai/build-planning#40
RAPIDS is adding support for Python 3.12 in its 24.10 release. All of the libraries used by images built from this repo (
cudf
,dask-cudf
,ucx-py
) have been updated... so this proposes adding Python 3.12 images here.Notes for Reviewers
How I tested this
On an x86_64 machine with CUDA driver 535: