Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax type-check in test_proxy.py #1321

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

rjzamora
Copy link
Member

There is a minor missing feature in dask-expr. I suggest we relax this test a bit to handle both "legacy" and "new" DataFrame collections.

@rjzamora rjzamora requested a review from a team as a code owner March 18, 2024 17:27
@github-actions github-actions bot added the python python code needed label Mar 18, 2024
@rjzamora rjzamora added bug Something isn't working 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed python python code needed improvement Improvement / enhancement to an existing function labels Mar 18, 2024
@rjzamora rjzamora added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Mar 18, 2024
@rjzamora
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 62c27d5 into rapidsai:branch-24.06 Mar 18, 2024
27 checks passed
@rjzamora rjzamora deleted the relax-type-check branch March 18, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants