Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELEASE] dask-cuda v24.06 #1341

Merged
merged 13 commits into from
Jun 5, 2024
Merged

[RELEASE] dask-cuda v24.06 #1341

merged 13 commits into from
Jun 5, 2024

Conversation

raydouglass
Copy link
Member

❄️ Code freeze for branch-24.06 and v24.06 release

What does this mean?

Only critical/hotfix level issues should be merged into branch-24.06 until release (merging of this PR).

What is the purpose of this PR?

  • Update documentation
  • Allow testing for the new release
  • Enable a means to merge branch-24.06 into main for the release

raydouglass and others added 12 commits March 15, 2024 12:00
There is a minor [missing feature in dask-expr](dask/dask-expr#985). I suggest we relax this test a bit to handle both "legacy" and "new" DataFrame collections.

Authors:
  - Richard (Rick) Zamora (https://github.com/rjzamora)

Approvers:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

URL: #1321
We should skip explicit-comms tests when dask-expr is active (for now).

Adding dask-expr support is part of #1311

Authors:
  - Richard (Rick) Zamora (https://github.com/rjzamora)

Approvers:
  - Peter Andreas Entschev (https://github.com/pentschev)

URL: #1322
Forward-merge branch-24.04 into branch-24.06 [skip ci]
It was brought to our attention that some links in our docs are broken, this change should fix those issues.

Closes #1328

Authors:
  - Peter Andreas Entschev (https://github.com/pentschev)
  - Ray Douglass (https://github.com/raydouglass)

Approvers:
  - Lawrence Mitchell (https://github.com/wence-)
  - Ray Douglass (https://github.com/raydouglass)

URL: #1329
Currently, each time an error occurs the CI test script will only trap the error code an switch it to a code `1` which is not representative of the underlying error that occurred. This makes it a bit difficult to identify the source of the error, particularly in cases where the test times out (exit code `124`) and there's no summary in the log.

This change captures and prints the last error code upon exit, but also logs all errors that may have occurred throughout execution where they occurred, thus facilitating debugging.

Authors:
  - Peter Andreas Entschev (https://github.com/pentschev)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #1330
Makes a few ~small~ changes to explicit-comms to support dask-expr.

EDIT: The changes are no longer "small".

Authors:
  - Richard (Rick) Zamora (https://github.com/rjzamora)
  - Peter Andreas Entschev (https://github.com/pentschev)

Approvers:
  - Peter Andreas Entschev (https://github.com/pentschev)
  - Jake Awe (https://github.com/AyodeAwe)

URL: #1323
Wireup may fail in UCX 1.16 in nodes with multiple NICs if TCP is used, thus skip those tests. UCX 1.17 will resolve the issue, and alternatively `UCX_PROTO_ENABLE=n` may be used in UCX 1.16 as well.

Authors:
  - Peter Andreas Entschev (https://github.com/pentschev)

Approvers:
  - Richard (Rick) Zamora (https://github.com/rjzamora)

URL: #1331
Forward-merge branch-24.04 into branch-24.06
This will make builds fail when there are path conflicts

Authors:
  - Jake Awe (https://github.com/AyodeAwe)

Approvers:
  - Joseph (https://github.com/jolorunyomi)

URL: #1325
Just a small fix to the license name for our scanning tool and to [be consistent with other repositories](https://github.com/rapidsai/cudf/blob/branch-24.06/python/cudf/pyproject.toml#L23).

Authors:
  - Ray Douglass (https://github.com/raydouglass)

Approvers:
  - Peter Andreas Entschev (https://github.com/pentschev)

URL: #1337
Proposes removing this project's build-time dependency on `tomli`.

It appears to no longer be necessary.

```shell
git grep tomli
```

## Notes for Reviewers

I originally noticed something similar in `ucx-py` (rapidsai/ucx-py#1042), then went searching for similar cases across RAPIDS.

I'm not sure why this project has a dependency on `tomli`, but I suspect it was related to the use of `versioneer` in this project's history. Reference: python-versioneer/python-versioneer#338 (comment)

This project doesn't use `versioneer` any more (#1204). I strongly suspect that the dependency on `tomli` can be removed.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - https://github.com/jakirkham
  - Ray Douglass (https://github.com/raydouglass)

URL: #1338
@raydouglass raydouglass requested review from a team as code owners May 24, 2024 19:35
@github-actions github-actions bot added python python code needed conda conda issue ci labels May 24, 2024
@raydouglass raydouglass merged commit d40b01f into main Jun 5, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci conda conda issue python python code needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants