Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove .gitattributes #1350

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

jameslamb
Copy link
Member

Contributes to rapidsai/build-planning#31

Removes .gitattributes file.

That was added in #88 for use with versioneer. Per the git docs (link), setting the attribute export-subst on a file via a .gitattributes tell git to replace placeholders in the file with some git information.

This is no longer done in _version.py files in this project, and this project no longer uses versioneer. rapids-build-backend handles storing git commit information in the published packages.

Notes for Reviewers

Created based on this conversation: rapidsai/kvikio#369 (comment)

@jameslamb jameslamb added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 18, 2024
@jameslamb jameslamb requested review from msarahan and bdice June 18, 2024 19:49
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jameslamb .

@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 7363b0c into rapidsai:branch-24.08 Jun 24, 2024
27 checks passed
@jameslamb jameslamb deleted the rm-gitattributes branch June 24, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants