Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary cmake and sccache configuration #1400

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

jameslamb
Copy link
Member

Contributes to rapidsai/build-planning#108

This is a pure Python project, so it doesn't need configuration about CMake or sccache.

This proposes removing them to simplify build scripts a bit.

It also proposes updating the rapids-dependency-file-generator pre-commit hook to it's latest version, something I'm trying to roll out across RAPIDS as part of rapidsai/build-planning#108.

@jameslamb jameslamb added 2 - In Progress Currently a work in progress improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 23, 2024
@github-actions github-actions bot added the ci label Oct 23, 2024
@jameslamb jameslamb removed the 2 - In Progress Currently a work in progress label Oct 23, 2024
@jameslamb jameslamb changed the title WIP: remove unnecessary cmake and sccache configuration remove unnecessary cmake and sccache configuration Oct 23, 2024
@jameslamb jameslamb marked this pull request as ready for review October 23, 2024 19:04
@jameslamb jameslamb requested a review from a team as a code owner October 23, 2024 19:04
@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 4639a96 into rapidsai:branch-24.12 Oct 23, 2024
27 checks passed
@jameslamb jameslamb deleted the ci-scripts branch October 23, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants