exit 1 if we can't generate creds using AWS_ROLE_ARN

rapidsai · Oct 27, 2024 · cfd41d6 · cfd41d6
1 parent b0dbf4f
commit cfd41d6
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/features/src/utils/devcontainer-feature.json b/features/src/utils/devcontainer-feature.json
@@ -1,7 +1,7 @@
 {
   "name": "devcontainer-utils",
   "id": "utils",
-  "version": "24.12.1",
+  "version": "24.12.2",
   "description": "A feature to install RAPIDS devcontainer utility scripts",
   "containerEnv": {
     "BASH_ENV": "/etc/bash.bash_env"

diff --git a/features/src/utils/opt/devcontainer/bin/creds/s3/generate.sh b/features/src/utils/opt/devcontainer/bin/creds/s3/generate.sh
@@ -14,7 +14,7 @@ _creds_s3_generate() {
     if test -n "${AWS_ROLE_ARN:-}" && gh nv-gha-aws --help >/dev/null 2>&1; then
         # shellcheck disable=SC1091
         devcontainer-utils-creds-s3-gh-generate;
-    elif test -n "${VAULT_HOST}"; then
+    elif test -n "${VAULT_HOST:-}"; then
         # shellcheck disable=SC1091
         devcontainer-utils-creds-s3-vault-generate;
     fi

diff --git a/features/src/utils/opt/devcontainer/bin/creds/s3/gh/generate.sh b/features/src/utils/opt/devcontainer/bin/creds/s3/gh/generate.sh
@@ -63,6 +63,7 @@ _creds_github_generate() {
         fi
     done
 
+    exit 1;
 }
 
 _creds_github_generate "$@" <&0;