-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make rapids-configure-conda-channels idempotent #104
Merged
jameslamb
merged 6 commits into
rapidsai:main
from
jameslamb:idempotent-configure-conda-channels
May 14, 2024
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8ec4627
make rapids-configure-conda-channels idempotent
jameslamb e278f17
Update tools/rapids-configure-conda-channels
jameslamb f1464ce
refactor, add -eou pipefail
jameslamb c4cf5bb
Merge branch 'main' into idempotent-configure-conda-channels
jameslamb 41566d5
Merge branch 'idempotent-configure-conda-channels' of github.com:jame…
jameslamb c57bebf
remove unused variable
jameslamb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,30 @@ | ||
#!/bin/bash | ||
# A utility script that configures conda channels | ||
|
||
set -euo pipefail | ||
|
||
conda_channel_in_config() { | ||
channel_id=${1:?err} | ||
conda config --json --get channels \ | ||
| channel_id="${channel_id}" jq -r --exit-status '.get.channels | any(. == env.channel_id )' | ||
} | ||
|
||
# Only try to run 'conda config --remove' if the channel exists in the config. | ||
# This is here to avoid errors if this script is invoked multiple times in the same environment. | ||
remove_conda_channel() { | ||
channel_id=${1:?err} | ||
if conda_channel_in_config "${channel_id}" > /dev/null; then | ||
conda config --system --remove channels "${channel_id}" | ||
else | ||
echo "[rapids-configure-conda-channels] channel '${channel_id}' not found via 'conda config --get channels'" | ||
fi | ||
} | ||
|
||
# Remove nightly channels if build is a release build | ||
if rapids-is-release-build; then | ||
conda config --system --remove channels rapidsai-nightly | ||
conda config --system --remove channels dask/label/dev | ||
remove_conda_channel 'rapidsai-nightly' | ||
remove_conda_channel 'dask/label/dev' | ||
else | ||
# exclude stable channel from all non-release builds. | ||
conda config --system --remove channels rapidsai | ||
remove_conda_channel 'rapidsai' | ||
fi |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposing adding this so we have a chance of catching the "there was a typo in the channel name" case.
In theory this should never show up in CI logs unless there's a problem, since this script should only be run once during CI jobs.