add opentelemery helper scripts (#119) #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msarahan
commented
Oct 14, 2024
msarahan
force-pushed
the
add-telemetry-traceparent-scripts
branch
from
d5f5b5d
to
af33721
Compare
msarahan
commented
Oct 30, 2024
| ${condaCmd} ${args} 2>&1| tee "${outfile}" | ||
| # RAPIDS_OTEL_WRAPPER is optionally passed in as an env var. It is | ||
| # used to instrument conda-build or mambabuild for finer-grained spans. | ||
| ${RAPIDS_OTEL_WRAPPER:-} ${condaCmd} ${args} 2>&1| tee "${outfile}" |
There was a problem hiding this comment.
This makes the wrapper opt-in, which I hope avoids any lingering possible issues that occurred last time we tried to add this. The wrapper won't be present at all unless it is added as an environment variable. This will happen in shared-workflows files.
ajschmidt8
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.