Fea/support cmake cuda architectures rapids value #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmaynard
added
feature request
bdice
requested changes
Dec 13, 2022
robertmaynard
force-pushed
the
fea/support-CMAKE_CUDA_ARCHITECTURES-RAPIDS-value
branch
from
46ab0da
to
b33a3ba
Compare
|
@gpucibot merge |
robertmaynard
deleted the
fea/support-CMAKE_CUDA_ARCHITECTURES-RAPIDS-value
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CMake 3.23+ now offers support for
allandall-majoras special keywords toCMAKE_CUDA_ARCHITECTURES. This means that rapids-cmake overload onALLnow creates confusion and breaks expectations ( trxcllnt/rapids-compose#84 https://gitlab.kitware.com/cmake/cmake/-/issues/23739, #104 )This PR introduces the new magic keyword of
RAPIDSwhich behaves the same asALL, and will become the new apporved approach for projects that want to build for RAPIDS supported platforms.Fixes #314
More details on the plans of deprecation for
ALLcan be found at: #318Checklist
cmake-format.jsonis up to date with these changes.