Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rapids_export_write_language no longer generates cmake dev warnings #712

Conversation

robertmaynard
Copy link
Contributor

Description

The rapids_export_write_language function would generate CMake code that would try and do set(var PARENT_SCOPE) in the root directory. This would cause CMake developer warnings to appear.

This resolves the issues by adding root level guards around the set commands, and setting up each rapids-cmake test to have developer warnings as errors. Due to #680 we mark some tests with NO_DEV_ERRORS so that they continue to pass while we wait to 2025 to bump the minimum required CMake version.

Checklist

@robertmaynard robertmaynard added bug Something isn't working non-breaking Introduces a non-breaking change labels Nov 4, 2024
@robertmaynard robertmaynard requested a review from a team as a code owner November 4, 2024 16:51
@robertmaynard
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit e867d76 into rapidsai:branch-24.12 Nov 6, 2024
15 checks passed
@robertmaynard robertmaynard deleted the bug/correct_export_language_warnings branch November 6, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants