rapids_export_write_language no longer generates cmake dev warnings #712
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
rapids_export_write_language
function would generate CMake code that would try and doset(var PARENT_SCOPE)
in the root directory. This would cause CMake developer warnings to appear.This resolves the issues by adding root level guards around the
set
commands, and setting up each rapids-cmake test to have developer warnings as errors. Due to #680 we mark some tests withNO_DEV_ERRORS
so that they continue to pass while we wait to 2025 to bump the minimum required CMake version.Checklist