Forward-merge branch-24.06 into branch-24.08 #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![rapids-bot[bot]](https://avatars.githubusercontent.com/in/85914?s=60&v=4){kind=small}
Module loads via `python -m *` take a different code path than direct usage of the dask/distributed CLI. The finder is still run to get the spec, but instead of the loader's `[create|exec]_module` methods being called next the loader's `get_code` method is called to simply load the `__main__` module as a text file to be executed directly. To support this use case, this PR splits up the finder and the loader. The loader is now a SourceFileLoader that is instantiated once per file to be loaded, allowing it to support loading the text of that file on demand by command line invocations. In order for this to work, the spec needs to be properly configured before the finder's `find_spec` call returns. The `update_spec` function I had in place before was a bit of a hack. This PR replaces that with a call to `importlib.util.find_spec` on the real module to get the full spec right up front. This allowed me to do quite a bit of other simplification; since the spec is now correct up front, I removed `update_spec` entirely and converted the loaders from stateful classes that updated the spec on load to simple factories since the spec is already guaranteed to be correct. Finally, I added some new tests of the CLI, module usage, and the accessor module. Closes #45 Closes rapidsai/docker#668 Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Richard (Rick) Zamora (https://github.com/rjzamora) URL: #46
|
SUCCESS - forward-merge complete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward-merge triggered by push to branch-24.06 that creates a PR to keep branch-24.08 up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See forward-merger docs for more info.