Skip to content

Commit

Permalink
Update to Cython 3.0.0 (#979)
Browse files Browse the repository at this point in the history
This PR bumps the pinning and fixes a couple of typing errors that were previously hidden.

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Peter Andreas Entschev (https://github.com/pentschev)
  - Ray Douglass (https://github.com/raydouglass)

URL: #979
  • Loading branch information
vyasr authored Aug 4, 2023
1 parent e2c1fce commit 7d230eb
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion dependencies.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ dependencies:
- output_types: [conda, requirements, pyproject]
packages:
- setuptools>=64.0.0
- cython>=0.29.14,<0.30.0a0
- cython>=3.0.0
- tomli # Not needed for Python 3.11+
run:
common:
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
[build-system]
build-backend = "setuptools.build_meta"
requires = [
"cython>=0.29.14,<0.30.0a0",
"cython>=3.0.0",
"setuptools>=64.0.0",
"tomli",
] # This list was generated by `rapids-dependency-file-generator`. To make changes, edit dependencies.yaml and run `rapids-dependency-file-generator`.
Expand Down
4 changes: 2 additions & 2 deletions ucp/_libs/ucx_worker.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ cdef _drain_worker_tag_recv(ucp_worker_h handle):

buf = malloc(info.length)
status = ucp_tag_msg_recv_nb(
handle, buf, info.length, ucp_dt_make_contig(1), message, _tag_recv_callback
handle, buf, info.length, ucp_dt_make_contig(1), message, _tag_recv_cb
)

try:
Expand Down Expand Up @@ -130,7 +130,7 @@ cdef class UCXWorker(UCXObject):
UCP_AM_HANDLER_PARAM_FIELD_ARG
)
am_handler_param.id = AM_MSG_ID
am_handler_param.cb = _am_recv_callback
am_handler_param.cb = <ucp_am_recv_callback_t>_am_recv_callback
am_handler_param.arg = <void *>self
status = ucp_worker_set_am_recv_handler(self._handle, &am_handler_param)

Expand Down

0 comments on commit 7d230eb

Please sign in to comment.