Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build wheels without build isolation #301

Merged
merged 10 commits into from
Oct 31, 2024
Merged

build wheels without build isolation #301

merged 10 commits into from
Oct 31, 2024

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Oct 16, 2024 •
edited
Loading

Description

Contributes to rapidsai/build-planning#108
Contributes to rapidsai/build-planning#111

Proposes some small packaging/CI changes, matching similar changes being made across RAPIDS.

  • building libucxx wheels with --no-build-isolation (for better sccache hit rate)
  • printing sccache stats to CI logs
  • updating to the latest rapids-dependency-file-generator (v1.16.0)
  • always explicitly specifying cpp / python in calls to rapids-upload-wheels-to-s3
  • moving more one-wheel-specific logic into build_wheel_{project}.sh scripts, mimicking how cudf has structured its scripts

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change DO NOT MERGE Hold off on merging; see PR for details labels Oct 16, 2024
@jameslamb jameslamb mentioned this pull request Oct 16, 2024
Closed
@jameslamb jameslamb mentioned this pull request Oct 22, 2024
Closed
@jameslamb jameslamb removed the DO NOT MERGE Hold off on merging; see PR for details label Oct 29, 2024
@jameslamb jameslamb changed the title WIP: [DO NOT MERGE] build wheels without build isolation build wheels without build isolation Oct 29, 2024
@jameslamb jameslamb marked this pull request as ready for review October 29, 2024 17:59
@jameslamb jameslamb requested a review from a team as a code owner October 29, 2024 17:59
bdice
bdice approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new scripts look cleaner. Everything seems fine.

@jameslamb
Copy link
Member Author

Thanks very much @bdice ! Yep I tried to follow cudf's patterns for these scripts.

@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 922b3a4 into rapidsai:branch-0.41 Oct 31, 2024
68 checks passed
@jameslamb jameslamb deleted the wheel-build-no-isolation branch October 31, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@msarahan msarahan Awaiting requested review from msarahan msarahan is a code owner automatically assigned from rapidsai/ci-codeowners

@pentschev pentschev Awaiting requested review from pentschev

Assignees
No one assigned
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jameslamb @bdice