XML destination - handle special characters

rapidwebltd · Mar 2, 2018 · a44453f · a44453f
1 parent 0c5cb13
commit a44453f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/src/Objects/Destinations/XMLDestination.php b/src/Objects/Destinations/XMLDestination.php
@@ -28,7 +28,7 @@ public function putDataRows(array $dataRows)
             $dataRowDomElement = $this->rootElement->appendChild(new DOMElement($this->rowElementName));
 
             foreach ($dataItems as $dataItem) {
-                $dataItemDomElement = new DOMElement($dataItem->fieldName, $dataItem->value);
+                $dataItemDomElement = new DOMElement($dataItem->fieldName, htmlspecialchars($dataItem->value));
                 $dataRowDomElement->appendChild($dataItemDomElement);
             }
         }

diff --git a/tests/Unit/XMLDestinationTest.php b/tests/Unit/XMLDestinationTest.php
@@ -23,6 +23,11 @@ private function createDataRows()
         $dataRow->addDataItem(new DataItem('value', $faker->randomNumber));
         $dataRows[] = $dataRow;
 
+        $dataRow = new DataRow();
+        $dataRow->addDataItem(new DataItem('name', 'special_characters_test_&<>'));
+        $dataRow->addDataItem(new DataItem('value', $faker->randomNumber));
+        $dataRows[] = $dataRow;
+
         return $dataRows;
     }
 
@@ -33,9 +38,9 @@ private function getExpectedFileContent(array $dataRows)
 
         foreach ($dataRows as $dataRow) {
             $expectedFileContent .= '<dataRow><name>';
-            $expectedFileContent .= $dataRow->getDataItemByFieldName('name')->value;
+            $expectedFileContent .= htmlspecialchars($dataRow->getDataItemByFieldName('name')->value);
             $expectedFileContent .= '</name><value>';
-            $expectedFileContent .= $dataRow->getDataItemByFieldName('value')->value;
+            $expectedFileContent .= htmlspecialchars($dataRow->getDataItemByFieldName('value')->value);
             $expectedFileContent .= '</value></dataRow>';
         }