Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Column/Filter Traits #2202

Merged
merged 18 commits into from
Feb 16, 2025

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Feb 15, 2025

This PR adjusts the namespaces for the Column/Filter traits, to ensure consistency, and enhance the developer experience

Ensuring that the relevant traits are nested within appropriate namespaces, it becomes more apparent what could be impacted by a change.

This PR is currently in active development, to ensure/maintain test coverage.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link

codecov bot commented Feb 15, 2025

Codecov Report

Attention: Patch coverage is 86.66667% with 14 lines in your changes missing coverage. Please review.

Project coverage is 89.73%. Comparing base (203d7ad) to head (ffb34f9).

Files with missing lines Patch % Lines
src/Views/Columns/LivewireComponentColumn.php 52.38% 10 Missing ⚠️
src/Views/Columns/ArrayColumn.php 70.00% 3 Missing ⚠️
src/Views/Actions/Traits/HasVisibility.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             development    #2202      +/-   ##
=================================================
- Coverage          89.94%   89.73%   -0.22%     
- Complexity          2136     2141       +5     
=================================================
  Files                242      247       +5     
  Lines               4803     4830      +27     
=================================================
+ Hits                4320     4334      +14     
- Misses               483      496      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrljoe
Copy link
Collaborator Author

lrljoe commented Feb 15, 2025

A touch further needed to restore an errantly removed trait from a particular Column, and some minor validation of the changes to needed

Need to restore a legacy reference to the component.

@lrljoe lrljoe merged commit c5b63fc into rappasoft:development Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant