-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor fixes #291
minor fixes #291
Conversation
d-kleine
commented
Jul 28, 2024
•
edited
Loading
edited
- fixed typos
- fixed formatting
- changed path call for better convenience
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
For reproducibility, you might add a context length to the model params (as in the instruction finetuning nb) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fixes look good to me. Much appreciated!
I originally had that, and was thinking about that, but I decided to remove it because it could lead to artificial truncation if someone uses it on a larger datasets with longer responses. |
Ah, I see - thanks! |
@rasbt Llama 3.1 models have been updated some days ago (due to issue with the tokenizer iirc), updates have now been pushed to the Ollama models too: Might be relevant for this nb (ch07/04_preference-tuning-with-dpo/create-preference-data-ollama.ipynb) You can update it with |
Thanks for the note! I think given that it doesn't change any of the settings, I'd leave it as is for now, but it's good to know! |