Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fixes #291

Merged
merged 2 commits into from
Jul 28, 2024
Merged

minor fixes #291

merged 2 commits into from
Jul 28, 2024

Conversation

d-kleine
Copy link
Contributor

@d-kleine d-kleine commented Jul 28, 2024

  • fixed typos
  • fixed formatting
  • changed path call for better convenience

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@d-kleine d-kleine changed the title minor fixed minor fixes Jul 28, 2024
@d-kleine d-kleine marked this pull request as ready for review July 28, 2024 14:49
@d-kleine
Copy link
Contributor Author

For reproducibility, you might add a context length to the model params (as in the instruction finetuning nb)

Copy link
Owner

@rasbt rasbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fixes look good to me. Much appreciated!

@rasbt rasbt merged commit 9a3b04f into rasbt:main Jul 28, 2024
8 checks passed
@rasbt
Copy link
Owner

rasbt commented Jul 28, 2024

For reproducibility, you might add a context length to the model params (as in the instruction finetuning nb)

I originally had that, and was thinking about that, but I decided to remove it because it could lead to artificial truncation if someone uses it on a larger datasets with longer responses.

@d-kleine
Copy link
Contributor Author

Ah, I see - thanks!

@d-kleine
Copy link
Contributor Author

fyi ollama/ollama#6060

@d-kleine
Copy link
Contributor Author

d-kleine commented Aug 6, 2024

@rasbt Llama 3.1 models have been updated some days ago (due to issue with the tokenizer iirc), updates have now been pushed to the Ollama models too:
https://ollama.com/library/llama3.1

Might be relevant for this nb (ch07/04_preference-tuning-with-dpo/create-preference-data-ollama.ipynb)

You can update it with ollama run llama3.1:70b, you might need to update Ollama before.

@rasbt
Copy link
Owner

rasbt commented Aug 7, 2024

Thanks for the note! I think given that it doesn't change any of the settings, I'd leave it as is for now, but it's good to know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants