Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clang related fixes #2231

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Clang related fixes #2231

merged 2 commits into from
Feb 5, 2025

Conversation

kilograham
Copy link
Contributor

  • Fix compilation on llvm 19 with picolibc
  • FIx disassembly of Arm floating point instructions on RP2350

@kilograham kilograham added this to the 2.1.1 milestone Feb 3, 2025
@kilograham
Copy link
Contributor Author

Note @will-v-pi i did a quick smoke test, but just worth checking if this trips up (or simplifies) any of the pioasm dissembly (dcp_ seemed fine)

@kilograham
Copy link
Contributor Author

fixes #2107

peterharperuk
peterharperuk approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@peterharperuk peterharperuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seemed to fix the build errors I was seeing.

@kilograham kilograham merged commit eb5c2c3 into develop Feb 5, 2025
8 checks passed
@kilograham kilograham deleted the clang-fixes branch February 5, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterharperuk peterharperuk peterharperuk approved these changes

@lurch lurch Awaiting requested review from lurch

@will-v-pi will-v-pi Awaiting requested review from will-v-pi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@kilograham @peterharperuk