Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency vite to v5 - abandoned #685

Closed
wants to merge 2 commits into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 17, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
vite (source) ^4.2.3 -> ^5.0.0 age adoption passing confidence

Release Notes

vitejs/vite (vite)

v5.0.7

Compare Source

v5.0.6

Compare Source

v5.0.5

Compare Source

v5.0.4

Compare Source

v5.0.3

Compare Source

v5.0.2

Compare Source

v5.0.1

v5.0.0

v4.5.1

Compare Source

Please refer to CHANGELOG.md for details.

v4.5.0

Compare Source

Please refer to CHANGELOG.md for details.

v4.4.12

Compare Source

Please refer to CHANGELOG.md for details.

v4.4.11

Compare Source

Please refer to CHANGELOG.md for details.

v4.4.10

Compare Source

Please refer to CHANGELOG.md for details.

v4.4.9

Compare Source

v4.4.8

Compare Source

v4.4.7

Compare Source

v4.4.6

Compare Source

v4.4.5

Compare Source

v4.4.4

Compare Source

v4.4.3

Compare Source

v4.4.2

Compare Source

v4.4.1

Compare Source

v4.4.0

Compare Source

Experimental support for Lightning CSS

Starting from Vite 4.4, there is experimental support for Lightning CSS. You can opt into it by adding css.transformer: 'lightningcss' to your config file and install the optional lightningcss dev dependency. If enabled, CSS files will be processed by Lightning CSS instead of PostCSS.

Lightning CSS can also be used as the CSS minifier with build.cssMinify: 'lightningcss'.

See beta docs at the Lighting CSS guide.

esbuild 0.18 update

esbuild 0.18 contains backwards-incompatible changes to esbuild's handling of tsconfig.json files. We think they shouldn't affect Vite users, you can review #​13525 for more information.

Templates for Solid and Qwik in create-vite

New starter templates have been added to create-vite for Solid and Qwik. Try them online at vite.new/solid-ts and vite.new/qwik-ts.

Korean Translation

Vite's docs are now translated to Korean, available at ko.vitejs.dev.

Features
Bug Fixes
Previous Changelogs
4.4.0-beta.4 (2023-07-03)

See 4.4.0-beta.4 changelog

4.4.0-beta.3 (2023-06-25)

See 4.4.0-beta.3 changelog

4.4.0-beta.2 (2023-06-22)

See 4.4.0-beta.2 changelog

4.4.0-beta.1 (2023-06-21)

See 4.4.0-beta.1 changelog

4.4.0-beta.0 (2023-06-20)

See 4.4.0-beta.0 changelog

v4.3.9

Compare Source

v4.3.8

Compare Source

v4.3.7

Compare Source

v4.3.6

Compare Source

v4.3.5

Compare Source

v4.3.4

Compare Source

v4.3.3

Compare Source

v4.3.2

Compare Source

  • fix: status optional in windows network drive regex (fix: [#​12948](https:

Configuration

📅 Schedule: Branch creation - "before 5:00am" in timezone America/Chicago, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot force-pushed the renovate/vite-5.x branch from f6b61b3 to 81bacee Compare December 4, 2023 11:31
Copy link
Collaborator

@MichaIng MichaIng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@renovate renovate bot force-pushed the renovate/vite-5.x branch from 81bacee to 7f8579f Compare December 19, 2023 15:07
@MichaIng
Copy link
Collaborator

MichaIng commented Dec 19, 2023

Okay, the manifest.json path is correct after my last commit, but the (I guess within referenced) favicon path is not (anymore). I guess you add it here: https://github.com/ravenclaw900/vite-embed/blob/036699b/vite-embed-macro/src/lib.rs#L227
And since the favicon will be outside of the .vite dir, it is not found anymore.

Not sure how to resolve best:

  1. Set manifest.json path to what it was before, which seems to be possible by using it a string instead of true for the related option.
  2. Use ../favicon.ico and ../index.html in vite-embed to follow the new vite v5 default manifest path.

I will try option 1 now, just to go forward and check other possible errors.

EDIT: Okay, that worked. Will test the assets, but it should be reviewed whether this is the wanted solution or vite-embed should be updated for vite v5 instead.

EDIT2: Binaries work fine.

@MichaIng MichaIng added the dependencies Pull requests that update a dependency file label Dec 19, 2023
Copy link
Contributor Author

renovate bot commented Dec 19, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@renovate renovate bot changed the title chore(deps): update dependency vite to v5 chore(deps): update dependency vite to v5 - abandoned Jan 20, 2024
Copy link
Contributor Author

renovate bot commented Jan 20, 2024

Autoclosing Skipped

This PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

@MichaIng MichaIng closed this Jun 13, 2024
@MichaIng MichaIng deleted the renovate/vite-5.x branch June 13, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant