Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HRINT-3675 Make build.ps1 work with older powershell #4

Merged
merged 1 commit into from
Jun 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions scripts/checkPrerequisites.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ function CheckPrerequisites () {
if ($null -eq $(Get-Command "dotnet" -ErrorAction SilentlyContinue)) {
throw "dotnet not found in path."
}

CheckLastExitCode

if ($PSVersionTable.PSVersion.Major -lt 5) {
throw "Incompatible Powershell version. Must be 5 or later."
Expand Down
3 changes: 2 additions & 1 deletion scripts/sign.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -67,11 +67,12 @@ function SignFile( $projectDir, $filePath, $dryRun) {
foreach ($time in $timeservers) {
try {
Write-Host "Command: $signTool sign /f `"$installerCert`" /p `"PASSWORD`" /d `"RavenDB`" /du `"https://ravendb.net`" /t `"$time`" /v /debug `"$filePath`""
exec { & $signTool sign /f "$installerCert" /p "$certPassword" /fd SHA256 /d "RavenDB" /du "https://ravendb.net" /tr "$time" /td SHA256 /v /debug "$filePath" }
& $signTool sign /f "$installerCert" /p "$certPassword" /fd SHA256 /d "RavenDB" /du "https://ravendb.net" /tr "$time" /td SHA256 /v /debug "$filePath"
CheckLastExitCode
return
}
catch {
Write-Error $_
continue
}
}
Expand Down
Loading