Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Either be As{Ref,Mut} over ?Sized types #38

Closed
wants to merge 2 commits into from

Conversation

nvzqz
Copy link
Contributor

@nvzqz nvzqz commented Jul 28, 2019

The blanket impl can cover all unsized types, removing the need for an impl per specific unsized type.

@cuviper
Copy link
Member

cuviper commented Jul 28, 2019

Please see the discussion in #28. I believe it is a breaking change to add a blanket T: ?Sized implementation -- or rather expanding the reach of the current blanket T. We've left that issue open to potentially address this in the future.

@bluss
Copy link
Contributor

bluss commented Oct 17, 2019

I'll close this since we don't have a plan for 2.0 at the moment.

Consider the different roles crates have. Crates that are used privately (local to a crate) have an easier time to go from 1.0 to 2.0. Say for example lazy_static. If you update that crate, it probably does not impact the public api of any crate.

Either is used for crate interchange in some ways, as part of the public api. Then it has ecosystem implications if we go from version 1 to 2, and crates need to update together to be compatible, some even are forced to bump from 1 to 2 themselves. At this point, I don't see evidence that we have enough to improve in either 2.0, for it to be worth the bump.

@bluss bluss closed this Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants