Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change design of Visit form to load errors into form #81

Merged
merged 2 commits into from
May 31, 2024

Conversation

dc2007git
Copy link
Contributor

@dc2007git dc2007git commented May 31, 2024

Before this PR, a user would have to go to a patient, and view all visits, in order to see which parts of the Visit form they have submitted have errors / aren't validated. These parts of the form, which we have named 'categories', would be highlighted in red if they had errors. However, when the user clicks on the form, they would have to memorise which parts of the form had errors as this information was not sustained in anyway on the next page by error messages or anything similar.

This PR introduces a colour-coordination to this problem. Any part of the form that has not had information filled into it will appear as dark blue, any part of the form where there are no errors (and the form is valid) will be pink, and any category part of the form where there are errors will show up as red.

This PR also incorporates a couple of minor bug fixes, such as removing rounded corners from the accordion in line with RCPCH styling.

Closes #77

@dc2007git dc2007git linked an issue May 31, 2024 that may be closed by this pull request
@eatyourpeas eatyourpeas self-assigned this May 31, 2024
Copy link
Member

@eatyourpeas eatyourpeas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @dc2007git. I will merge this but still work in progress. In particular, if all the tiles are to be pink if complete, red if invalid and dark blue if unscored, we should roll that same style across all the fields in each tab.
Also the red and pink clash quite a lot, so we need to think about ways to make it easier on the eye...

@eatyourpeas eatyourpeas merged commit a86bf06 into development May 31, 2024
2 checks passed
@eatyourpeas eatyourpeas deleted the 77-add-flagging-of-errors-to-visit-form branch May 31, 2024 20:18
@dc2007git dc2007git mentioned this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add flagging of errors to Visit form
2 participants