Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bmi-error #46

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Bmi-error #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8293fcf
fix bmi error threshold
eatyourpeas Nov 5, 2024
b3173e3
Bump version: 4.2.4 → 4.2.5
eatyourpeas Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .bumpversion.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[bumpversion]
current_version = 4.2.4
current_version = 4.2.5
tag = False
commit = True

Expand Down
2 changes: 1 addition & 1 deletion rcpchgrowth/measurement.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,7 +621,7 @@ def __validate_measurement_method(
elif observation_value_z_score < MINIMUM_BMI_ERROR_SDS:
raise ValueError(
f'The Body Mass Index measurement of {observation_value} kg/m² is below -15 SD and considered to be an error.')
elif observation_value_z_score > MAXIMUM_BMI_KGM2:
elif observation_value_z_score > MAXIMUM_BMI_ERROR_SDS:
raise ValueError(
f'The Body Mass Index measurement of {observation_value} kg/m² is above +15 SD and considered to be an error.')
else:
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

setup(
name="rcpchgrowth",
version="4.2.4",
version="4.2.5",
description="SDS and Centile calculations for UK Growth Data",
long_description=long_description,
url="https://github.com/rcpch/digital-growth-charts/blob/master/README.md",
Expand Down
Loading