Tests TBD osut050 branch #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brgix
commented
Apr 7, 2024
| @@ -6845,7 +6853,7 @@ | |||
|
|
|||
| # Same exercise, yet provide clerestory with Frame & Divider. | |||
| fd2 = OpenStudio::Model::WindowPropertyFrameAndDivider.new(model_FD) | |||
| width2 = 0.03 | |||
| width2 = 0.06 | |||
There was a problem hiding this comment.
This adjustment is now required for OpenStudio SDK versions v3.2.1 through v3.3.0, as described here. Previously, TBD only relied on OSut's (older) overlaps? method (returning true or false) to detect whether 2 polygons intersected (e.g. when dealing with Frame & Divider widths). OSut's overlaps? will soon depend on a related overlap method (which instead returns the actual intersecting polygon, relying on OpenStudio.intersect function). As discussed in the quoted OSut PR comment, v3.2.1 and v3.3.0 OpenStudio.intersect versions do not catch narrow intersections (like narrow window frames). Version v3.0.0, as well as any version > 3.3.0, work just fine. So simply relaxing the test here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preliminary testing of OSut (branch "geo"), a TBD dependency. Although 99% done, there are likely minor improvements to add to OSut before releasing later this month. Very minor adjustments are expected for TBD (i.e. no anticipated change in test results).