Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs for grabbed self col checking due to asymmetricity and unordered-ness. #1438

Open
wants to merge 32 commits into
base: production
Choose a base branch
from

Commits on Sep 25, 2024

  1. Fix the incorrect computation of self collision for grabbed bodies.

    - Issue
      - This commit tries to improve the reported issue1, issue2, and issue3 : #1436
      - Previously, _listNonCollidingLinksWhenGrabbed is asymmetric : the results obtained from grabbedBody1 is not same as the results obtained from grabbedBody2.
      - However, many codes in CheckSelfCollision assumes it's symmetric. The assumption was broken. In addition, such breakage was amplified after #1421.
    - Resolution
      - Instead of store the target link like the previous _listNonCollidingLinksWhenGrabbed_, store the information about the link pairs. This is more accurate and the same methodologies as non-adjacent-links in self colision checking.
      - Separate grabbed-grabber link pair and inter-grabbed link pair.
         - grabbed-grabber link pair, e.g. object-robot link pair, still exists in the Grabbed class as before.
         - inter-grabbed link pair now exists in the KinBody class, since if it's held in Grabbed, it becomes inconsistent and asymmetric.
      - Following the same methodologies in #1421, inter-grabbed link pairs are stored as unordered_map, and its key is combined env body indices of two grabbed bodies.
    Shunichi Nozawa committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    2198a21 View commit details
    Browse the repository at this point in the history
  2. reduce the duplicated checking of pointer validity. check it when cre…

    …ating the vector.
    Shunichi Nozawa committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    0cd3346 View commit details
    Browse the repository at this point in the history
  3. use _mapListNonCollidingInterGrabbedLinkPairsWhenGrabbed and _listNon…

    …CollidingGrabbedGrabberLinkPairsWhenGrabbed in CheckSelfCollisionChecking
    Shunichi Nozawa committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    a942ee1 View commit details
    Browse the repository at this point in the history
  4. directly return from the function if collision is deteced when bAllLi…

    …nkCollisions==false. also share the utilities for CollisioReport update and printing.
    Shunichi Nozawa committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    d7b510e View commit details
    Browse the repository at this point in the history
  5. Improve warning message more

    Shunichi Nozawa committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    8fdf9eb View commit details
    Browse the repository at this point in the history
  6. fix wrong size

    Shunichi Nozawa committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    042243f View commit details
    Browse the repository at this point in the history
  7. fix typo of pSecondLink. in addition, rename variable to contain 'Ref…

    …' to clarify meaning.
    Shunichi Nozawa committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    a8839a2 View commit details
    Browse the repository at this point in the history
  8. improve comments

    Shunichi Nozawa committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    7841daf View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Resolve conflict while merge production. Conflicts: include/openrave/…

    …kinbody.h
    Shunichi Nozawa committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    61dc5dc View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Merge remote-tracking branch 'origin/production' into fixGrabbedSelfC…

    …olCheckAsym
    Shunichi Nozawa committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    c3e9253 View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'origin/miscCleanupForGrabbedAPIs' into …

    …fixGrabbedSelfColCheckAsym
    Shunichi Nozawa committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    d8dcfeb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2bdbdb3 View commit details
    Browse the repository at this point in the history
  4. Merge remote-tracking branch 'origin/miscCleanupForGrabbedAPIs' into …

    …fixGrabbedSelfColCheckAsym
    Shunichi Nozawa committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    4645c51 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. Merge remote-tracking branch 'origin/miscCleanupForGrabbedAPIs' into …

    …fixGrabbedSelfColCheckAsym
    Shunichi Nozawa committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    78088f7 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Merge remote-tracking branch 'origin/miscCleanupForGrabbedAPIs' into …

    …fixGrabbedSelfColCheckAsym
    Shunichi Nozawa committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    21b37e5 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Merge remote-tracking branch 'origin/miscCleanupForGrabbedAPIs' into …

    …fixGrabbedSelfColCheckAsym
    Shunichi Nozawa committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    bb7cc24 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2024

  1. Resolve conflict while merge production. Conflicts: src/libopenrave/k…

    …inbodystatesaver.cpp.
    Shunichi Nozawa committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    9270541 View commit details
    Browse the repository at this point in the history
  2. Fix compile

    Shunichi Nozawa committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    2856b8d View commit details
    Browse the repository at this point in the history
  3. use |

    Shunichi Nozawa committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    f5a663d View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Merge remote-tracking branch 'origin/production' into fixGrabbedSelfC…

    …olCheckAsym
    Shunichi Nozawa committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    16bd21f View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Configuration menu
    Copy the full SHA
    0ae0e0e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fa2cc0c View commit details
    Browse the repository at this point in the history
  3. no need of bInvertFirstSecond

    Shunichi Nozawa committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    e21a2e7 View commit details
    Browse the repository at this point in the history
  4. Swap the order of code, for better readability

    Shunichi Nozawa committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    8bf75a0 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. return value from here is unused

    Shunichi Nozawa committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    e7cd291 View commit details
    Browse the repository at this point in the history
  2. Update warning message clearer.

    Shunichi Nozawa committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    05c9441 View commit details
    Browse the repository at this point in the history
  3. Introduce the rule of indices pair, which is key of map. the first en…

    …vBodyIndex should be always smaller than the second envBodyIndex to simplify the searching.
    Shunichi Nozawa committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    d9f6275 View commit details
    Browse the repository at this point in the history
  4. Bump minor version to fix bug of _listNonColidingLinksWhenGrabbed asy…

    …mmetricity.
    Shunichi Nozawa committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    d8a7d4f View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. Merge remote-tracking branch 'origin/production' into fixGrabbedSelfC…

    …olCheckAsym
    Shunichi Nozawa committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    35fc6f9 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Resolve conflict while merge production. CMakeLists.txt, docs/source/…

    …changelog.rst
    Shunichi Nozawa committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    b1599de View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2024

  1. Configuration menu
    Copy the full SHA
    179f48e View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. Configuration menu
    Copy the full SHA
    f6f4f50 View commit details
    Browse the repository at this point in the history