-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bugs for grabbed self col checking due to asymmetricity and unordered-ness. #1438
base: production
Are you sure you want to change the base?
Commits on Sep 25, 2024
-
Fix the incorrect computation of self collision for grabbed bodies.
- Issue - This commit tries to improve the reported issue1, issue2, and issue3 : #1436 - Previously, _listNonCollidingLinksWhenGrabbed is asymmetric : the results obtained from grabbedBody1 is not same as the results obtained from grabbedBody2. - However, many codes in CheckSelfCollision assumes it's symmetric. The assumption was broken. In addition, such breakage was amplified after #1421. - Resolution - Instead of store the target link like the previous _listNonCollidingLinksWhenGrabbed_, store the information about the link pairs. This is more accurate and the same methodologies as non-adjacent-links in self colision checking. - Separate grabbed-grabber link pair and inter-grabbed link pair. - grabbed-grabber link pair, e.g. object-robot link pair, still exists in the Grabbed class as before. - inter-grabbed link pair now exists in the KinBody class, since if it's held in Grabbed, it becomes inconsistent and asymmetric. - Following the same methodologies in #1421, inter-grabbed link pairs are stored as unordered_map, and its key is combined env body indices of two grabbed bodies.
Shunichi Nozawa committedSep 25, 2024 Configuration menu - View commit details
-
Copy full SHA for 2198a21 - Browse repository at this point
Copy the full SHA 2198a21View commit details -
reduce the duplicated checking of pointer validity. check it when cre…
…ating the vector.
Shunichi Nozawa committedSep 25, 2024 Configuration menu - View commit details
-
Copy full SHA for 0cd3346 - Browse repository at this point
Copy the full SHA 0cd3346View commit details -
use _mapListNonCollidingInterGrabbedLinkPairsWhenGrabbed and _listNon…
…CollidingGrabbedGrabberLinkPairsWhenGrabbed in CheckSelfCollisionChecking
Shunichi Nozawa committedSep 25, 2024 Configuration menu - View commit details
-
Copy full SHA for a942ee1 - Browse repository at this point
Copy the full SHA a942ee1View commit details -
directly return from the function if collision is deteced when bAllLi…
…nkCollisions==false. also share the utilities for CollisioReport update and printing.
Shunichi Nozawa committedSep 25, 2024 Configuration menu - View commit details
-
Copy full SHA for d7b510e - Browse repository at this point
Copy the full SHA d7b510eView commit details -
Shunichi Nozawa committed
Sep 25, 2024 Configuration menu - View commit details
-
Copy full SHA for 8fdf9eb - Browse repository at this point
Copy the full SHA 8fdf9ebView commit details -
Shunichi Nozawa committed
Sep 25, 2024 Configuration menu - View commit details
-
Copy full SHA for 042243f - Browse repository at this point
Copy the full SHA 042243fView commit details -
fix typo of pSecondLink. in addition, rename variable to contain 'Ref…
…' to clarify meaning.
Shunichi Nozawa committedSep 25, 2024 Configuration menu - View commit details
-
Copy full SHA for a8839a2 - Browse repository at this point
Copy the full SHA a8839a2View commit details -
Shunichi Nozawa committed
Sep 25, 2024 Configuration menu - View commit details
-
Copy full SHA for 7841daf - Browse repository at this point
Copy the full SHA 7841dafView commit details
Commits on Sep 26, 2024
-
Resolve conflict while merge production. Conflicts: include/openrave/…
…kinbody.h
Shunichi Nozawa committedSep 26, 2024 Configuration menu - View commit details
-
Copy full SHA for 61dc5dc - Browse repository at this point
Copy the full SHA 61dc5dcView commit details
Commits on Sep 30, 2024
-
Merge remote-tracking branch 'origin/production' into fixGrabbedSelfC…
…olCheckAsym
Shunichi Nozawa committedSep 30, 2024 Configuration menu - View commit details
-
Copy full SHA for c3e9253 - Browse repository at this point
Copy the full SHA c3e9253View commit details -
Merge remote-tracking branch 'origin/miscCleanupForGrabbedAPIs' into …
…fixGrabbedSelfColCheckAsym
Shunichi Nozawa committedSep 30, 2024 Configuration menu - View commit details
-
Copy full SHA for d8dcfeb - Browse repository at this point
Copy the full SHA d8dcfebView commit details -
Add missing post processing of check self collision at the very end.
Shunichi Nozawa committedSep 30, 2024 Configuration menu - View commit details
-
Copy full SHA for 2bdbdb3 - Browse repository at this point
Copy the full SHA 2bdbdb3View commit details -
Merge remote-tracking branch 'origin/miscCleanupForGrabbedAPIs' into …
…fixGrabbedSelfColCheckAsym
Shunichi Nozawa committedSep 30, 2024 Configuration menu - View commit details
-
Copy full SHA for 4645c51 - Browse repository at this point
Copy the full SHA 4645c51View commit details
Commits on Oct 10, 2024
-
Merge remote-tracking branch 'origin/miscCleanupForGrabbedAPIs' into …
…fixGrabbedSelfColCheckAsym
Shunichi Nozawa committedOct 10, 2024 Configuration menu - View commit details
-
Copy full SHA for 78088f7 - Browse repository at this point
Copy the full SHA 78088f7View commit details
Commits on Oct 17, 2024
-
Merge remote-tracking branch 'origin/miscCleanupForGrabbedAPIs' into …
…fixGrabbedSelfColCheckAsym
Shunichi Nozawa committedOct 17, 2024 Configuration menu - View commit details
-
Copy full SHA for 21b37e5 - Browse repository at this point
Copy the full SHA 21b37e5View commit details
Commits on Oct 18, 2024
-
Merge remote-tracking branch 'origin/miscCleanupForGrabbedAPIs' into …
…fixGrabbedSelfColCheckAsym
Shunichi Nozawa committedOct 18, 2024 Configuration menu - View commit details
-
Copy full SHA for bb7cc24 - Browse repository at this point
Copy the full SHA bb7cc24View commit details
Commits on Oct 19, 2024
-
Resolve conflict while merge production. Conflicts: src/libopenrave/k…
…inbodystatesaver.cpp.
Shunichi Nozawa committedOct 19, 2024 Configuration menu - View commit details
-
Copy full SHA for 9270541 - Browse repository at this point
Copy the full SHA 9270541View commit details -
Shunichi Nozawa committed
Oct 19, 2024 Configuration menu - View commit details
-
Copy full SHA for 2856b8d - Browse repository at this point
Copy the full SHA 2856b8dView commit details -
Shunichi Nozawa committed
Oct 19, 2024 Configuration menu - View commit details
-
Copy full SHA for f5a663d - Browse repository at this point
Copy the full SHA f5a663dView commit details
Commits on Oct 21, 2024
-
Merge remote-tracking branch 'origin/production' into fixGrabbedSelfC…
…olCheckAsym
Shunichi Nozawa committedOct 21, 2024 Configuration menu - View commit details
-
Copy full SHA for 16bd21f - Browse repository at this point
Copy the full SHA 16bd21fView commit details
Commits on Oct 22, 2024
-
Add kinematics hash checking for map list noncolliding for inter grabbed
Shunichi Nozawa committedOct 22, 2024 Configuration menu - View commit details
-
Copy full SHA for 0ae0e0e - Browse repository at this point
Copy the full SHA 0ae0e0eView commit details -
No need to check iterator since the code right before already checked it
Shunichi Nozawa committedOct 22, 2024 Configuration menu - View commit details
-
Copy full SHA for fa2cc0c - Browse repository at this point
Copy the full SHA fa2cc0cView commit details -
Shunichi Nozawa committed
Oct 22, 2024 Configuration menu - View commit details
-
Copy full SHA for e21a2e7 - Browse repository at this point
Copy the full SHA e21a2e7View commit details -
Swap the order of code, for better readability
Shunichi Nozawa committedOct 22, 2024 Configuration menu - View commit details
-
Copy full SHA for 8bf75a0 - Browse repository at this point
Copy the full SHA 8bf75a0View commit details
Commits on Oct 25, 2024
-
return value from here is unused
Shunichi Nozawa committedOct 25, 2024 Configuration menu - View commit details
-
Copy full SHA for e7cd291 - Browse repository at this point
Copy the full SHA e7cd291View commit details -
Update warning message clearer.
Shunichi Nozawa committedOct 25, 2024 Configuration menu - View commit details
-
Copy full SHA for 05c9441 - Browse repository at this point
Copy the full SHA 05c9441View commit details -
Introduce the rule of indices pair, which is key of map. the first en…
…vBodyIndex should be always smaller than the second envBodyIndex to simplify the searching.
Shunichi Nozawa committedOct 25, 2024 Configuration menu - View commit details
-
Copy full SHA for d9f6275 - Browse repository at this point
Copy the full SHA d9f6275View commit details -
Bump minor version to fix bug of _listNonColidingLinksWhenGrabbed asy…
…mmetricity.
Shunichi Nozawa committedOct 25, 2024 Configuration menu - View commit details
-
Copy full SHA for d8a7d4f - Browse repository at this point
Copy the full SHA d8a7d4fView commit details
Commits on Oct 28, 2024
-
Merge remote-tracking branch 'origin/production' into fixGrabbedSelfC…
…olCheckAsym
Shunichi Nozawa committedOct 28, 2024 Configuration menu - View commit details
-
Copy full SHA for 35fc6f9 - Browse repository at this point
Copy the full SHA 35fc6f9View commit details
Commits on Oct 31, 2024
-
Resolve conflict while merge production. CMakeLists.txt, docs/source/…
…changelog.rst
Shunichi Nozawa committedOct 31, 2024 Configuration menu - View commit details
-
Copy full SHA for b1599de - Browse repository at this point
Copy the full SHA b1599deView commit details
Commits on Nov 3, 2024
-
Resolve conflict while merge master. Conflict. docs/source/changelog.rst
Shunichi Nozawa committedNov 3, 2024 Configuration menu - View commit details
-
Copy full SHA for 179f48e - Browse repository at this point
Copy the full SHA 179f48eView commit details
Commits on Nov 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f6f4f50 - Browse repository at this point
Copy the full SHA f6f4f50View commit details