Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception / assert confusion #1462

Open
wants to merge 3 commits into
base: production
Choose a base branch
from
Open

Exception / assert confusion #1462

wants to merge 3 commits into from

Conversation

lazydroid
Copy link
Collaborator

@lazydroid lazydroid commented Nov 5, 2024 •
edited
Loading

The following statement does approximately nothing. Exceptions should be thrown.

OPENRAVE_EXCEPTION_FORMAT0(num == info._voffsets.size(), ORE_InvalidState);

Probably, this is what was expected:

OPENRAVE_ASSERT_FORMAT0(num == info._voffsets.size(), _("unexpected size"), ORE_InvalidState);

@lazydroid lazydroid changed the base branch from master to production November 5, 2024 11:12
@lazydroid lazydroid self-assigned this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshikikanemoto yoshikikanemoto Awaiting requested review from yoshikikanemoto

Assignees

@lazydroid lazydroid

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lazydroid